src/gitops/utils/components/LoadingSpinner/Loading.tsx (1)

4-14: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Reorder declarations for readability.

LoadingInline (Line 4) references Loading before it is declared (Line 7). It works because the reference is inside a deferred function body, but declaring Loading first improves readability.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/gitops/utils/components/LoadingSpinner/Loading.tsx` around lines 4 - 14,
Reorder the component declarations in Loading.tsx so Loading is defined before
LoadingInline for readability. Keep the behavior the same by leaving
LoadingInline as a thin wrapper around Loading and preserving
LoadingInline.displayName, but move the Loading function declaration above
LoadingInline to make the dependency order explicit.

src/gitops/components/rollout/RolloutRevisionsTab.tsx (1)

67-68: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Nested ternary flagged by ESLint.

Consider refactoring to an early-return/if-else style for readability, per the static analysis hint (no-nested-ternary).

♻️ Suggested refactor

-      {loadError || podsloadError ? (
-        <div>
-          ...
-        </div>
-      ) : !loaded || !podsloaded ? (
-        <Loading />
-      ) : (
-        <Revisions
-          rollout={rollout}
-          replicaSets={resourceAsArray(replicaSets) as ReplicaSetKind[]}
-          pods={resourceAsArray(pods) as PodKind[]}
-        />
-      )}
+      {(() => {
+        if (loadError || podsloadError) {
+          return (
+            <div>
+              ...
+            </div>
+          );
+        }
+        if (!loaded || !podsloaded) {
+          return <Loading />;
+        }
+        return (
+          <Revisions
+            rollout={rollout}
+            replicaSets={resourceAsArray(replicaSets) as ReplicaSetKind[]}
+            pods={resourceAsArray(pods) as PodKind[]}
+          />
+        );
+      })()}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/gitops/components/rollout/RolloutRevisionsTab.tsx` around lines 67 - 68,
The conditional rendering in RolloutRevisionsTab is using a nested ternary that
triggers the no-nested-ternary lint rule. Refactor the JSX in
RolloutRevisionsTab to use early returns or a simple if/else sequence instead of
chaining ternary branches, keeping the same loading/empty/main render behavior
while making the render logic easier to read and maintain.

Source: Linters/SAST tools

src/gitops/topology/console/pod-traffic.tsx (1)

27-44: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Remove dead commented-out code instead of leaving it in-place.

The old LoadingInline/Loading/LoadingProps implementations are commented out rather than deleted now that they've been moved to the shared module. Leaving this dead code adds clutter.

🧹 Suggested cleanup

-// export const LoadingInline: React.FunctionComponent = () => <Loading isInline />;
-// LoadingInline.displayName = 'LoadingInline';
-
-// export const Loading: React.FunctionComponent<LoadingProps> = ({ className, isInline }) => (
-//   <div
-//     className={classNames('co-m-loader', { 'co-m-loader--inline': isInline }, className)}
-//     data-test="loading-indicator"
-//   >
-//     <Spinner aria-live="polite" aria-busy="true" isInline={isInline} size="lg" />
-//   </div>
-// );
-
-// Loading.displayName = 'Loading';
-
-// type LoadingProps = {
-//   className?: string;
-//   isInline?: boolean;
-// };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/gitops/topology/console/pod-traffic.tsx` around lines 27 - 44, Remove the
commented-out LoadingInline, Loading, and LoadingProps block from
pod-traffic.tsx since those implementations now live in the shared module. Clean
up the dead code in this area and keep the file focused on the active pod
traffic logic and any remaining references to LoadingInline/Loading that are
still in use.